Dan Kenigsberg has posted comments on this change. Change subject: report cpuUser and cpuSys separately ......................................................................
Patch Set 3: (1 inline comment) .................................................... File vdsm/libvirtvm.py Line 172: def _getCpuStats(self, stats): Line 173: sInfo, eInfo, sampleInterval = self.sampleCpu.getStats() Line 174: Line 175: try: Line 176: stats['cpuSys'] = self._usagePercentage( if you are changing the Engine/Vdsm API, please consider libvirt's model (of 3 values) even though I do not quite understand it myself. I can personally live with the awkward naming, if a big fat documentation is attached to it. Line 177: self._diff(eInfo, sInfo, 'user_time') Line 178: + self._diff(eInfo, sInfo, 'system_time'), Line 179: sampleInterval) Line 180: stats['cpuUser'] = self._usagePercentage( -- To view, visit http://gerrit.ovirt.org/7718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I663ad25ff3ff5ce426b5159b6c9a65b7f5167605 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Gal Hammer <[email protected]> Gerrit-Reviewer: Geert Jansen <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
