Dan Kenigsberg has posted comments on this change. Change subject: report cpuUser and cpuSys separately (#800367) ......................................................................
Patch Set 5: I would prefer that you didn't submit this (3 inline comments) .................................................... Commit Message Line 5: CommitDate: 2012-09-25 06:35:04 +0200 Line 6: Line 7: report cpuUser and cpuSys separately (#800367) Line 8: Line 9: https://bugzilla.redhat.com/800367 Bug-Url: tag helps some scripts Line 10: Line 11: Uses virDomainGetCPUStats to get the CPU information instead of info() Line 12: The content of the exported 'cpuSys' and 'cpuUser' changes: Line 13: - cpuSys is the sum of system_time and user_time reported by libvirt Line 13: - cpuSys is the sum of system_time and user_time reported by libvirt Line 14: since none of these include the guest time Line 15: - cpuUser is the time consumed only by the guest VM without the Line 16: system_time and the user_time Line 17: would you add here the outcome of your libvirt research? does this patch have any considerable change to the stats reported by a normal functioning VM? Please add an "apology" that this awkwardness is done in order to keep current api. Line 18: Change-Id: I663ad25ff3ff5ce426b5159b6c9a65b7f5167605 .................................................... File vdsm_api/vdsmapi-schema.json Line 4536: # @boot: #optional An alias for the type of device used to boot the VM Line 4537: # Line 4538: # @statsAge: The age of these statistics in seconds Line 4539: # Line 4540: # @cpuSys: Ratio of CPU time spent by the qemu process on other than guest time keep lines shorter, please. Line 4541: # Line 4542: # @cpuUser: Ratio of CPU time spent by the guest VM Line 4543: # Line 4544: # @acpiEnable: Indicates if ACPI is enabled inside the VM -- To view, visit http://gerrit.ovirt.org/7718 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I663ad25ff3ff5ce426b5159b6c9a65b7f5167605 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Gal Hammer <[email protected]> Gerrit-Reviewer: Geert Jansen <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Royce Lv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
