Dan Kenigsberg has posted comments on this change.
Change subject: bootstrap: use yum API
......................................................................
Patch Set 1: (4 inline comments)
yeah, I must find the peace of mind to look deeper.
....................................................
File vds_bootstrap/Makefile.am
Line 43: interface2dir=$(vdsmbootstrapdir)/interface-2
Line 44: dist_interface2_SCRIPTS = \
Line 45: vds_bootstrap_complete.py \
Line 46: vds_bootstrap.py \
Line 47: MiniYum.py \
no, classes are CamelCase
Line 48: setup
Line 49:
Line 50: nodist_interface2_SCRIPTS = \
Line 51: deployUtil.py
....................................................
File vds_bootstrap/MiniYum.py
Line 434: return True
Line 435:
Line 436:
Line 437: def main():
Line 438: gluster = False
in "this" you mean this whole file? it was not clear to me.
Line 439:
Line 440: # BEGIN: PROCESS-INITIALIZATION
Line 441: miniyumsink = myminiyumsink()
Line 442: MiniYum.setup_log_hook(miniyumsink)
Line 447: except Exception, e:
Line 448: print "FAILED: cannot initialize selinux: " + str(e)
Line 449: # END: PROCESS-INITIALIZATION
Line 450:
Line 451: with miniyum:
I see this. imo miniyum does too much unrelated stuff. the transaction
semantics seems interesting enough to be exposed, maybe as
MiniYum.transaction
?
Line 452: miniyum.clean()
Line 453:
Line 454: with miniyum:
Line 455: try:
Line 451: with miniyum:
Line 452: miniyum.clean()
Line 453:
Line 454: with miniyum:
Line 455: try:
examples should have well-styled code, too.
Line 456: miniyum.remove(('cman',), ignoreErrors=True)
Line 457: miniyum.install(('qemu-kvm-tools',))
Line 458: miniyum.installUpdate(('vdsm', 'vdsm-cli'))
Line 459: if gluster:
--
To view, visit http://gerrit.ovirt.org/8039
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65796801bc2db7c5abf71c1e9e4ad8ca308138b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Pradipta Banerjee <[email protected]>
Gerrit-Reviewer: Rodrigo Trujillo <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
