Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: use yum API
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File vds_bootstrap/MiniYum.py
Line 409: """
Line 410: We dup the stdout as during yum operation
Line 411: we redirect it.
Line 412: """
Line 413: self._stream = None
Not closed... it is dup() not dup2().
Line 414: self._stream = os.dup(sys.stdout.fileno())
Line 415:
Line 416: def __del__(self):
Line 417: if self._stream is not None:
....................................................
File vds_bootstrap/vds_bootstrap.py
Line 961:
Line 962: if miniyum is not None:
Line 963: try:
Line 964: with miniyum:
Line 965: miniyum.clean()
Yes. as there are cases we will have hash errors on files.
Anyway, this is also our current behaviour.
Line 966:
Line 967: with miniyum:
Line 968: miniyum.remove(('cman',), ignoreErrors=True)
Line 969: miniyum.install(('qemu-kvm-tools',))
Line 967: with miniyum:
Line 968: miniyum.remove(('cman',), ignoreErrors=True)
Line 969: miniyum.install(('qemu-kvm-tools',))
Line 970: miniyum.installUpdate(('vdsm', 'vdsm-cli'))
Line 971:
I don't see any benefit in holding globals that are used once and detached from
their context.
Line 972: if installGlusterService:
Line 973: miniyum.install(('glusterfs-rdma',
'glusterfs-geo-replication'))
Line 974: miniyum.installUpdate(('vdsm-gluster',))
Line 975:
--
To view, visit http://gerrit.ovirt.org/8039
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65796801bc2db7c5abf71c1e9e4ad8ca308138b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Pradipta Banerjee <[email protected]>
Gerrit-Reviewer: Rodrigo Trujillo <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
