Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: use yum API ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vds_bootstrap/MiniYum.py Line 409: """ Line 410: We dup the stdout as during yum operation Line 411: we redirect it. Line 412: """ Line 413: self._stream = None would you educate me? when and why would os.dup fail? When stdout is already closed? Line 414: self._stream = os.dup(sys.stdout.fileno()) Line 415: Line 416: def __del__(self): Line 417: if self._stream is not None: -- To view, visit http://gerrit.ovirt.org/8039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65796801bc2db7c5abf71c1e9e4ad8ca308138b9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Pradipta Banerjee <[email protected]> Gerrit-Reviewer: Rodrigo Trujillo <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
