Edward Haas has posted comments on this change. Change subject: net: mtu should be reported as a string through caps ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51164/1/lib/vdsm/netinfo/__init__.py File lib/vdsm/netinfo/__init__.py: Line 101: def stringify_mtus(networking): Line 102: # REQUIRED_FOR engine < 3.7 Line 103: for devtype in ('bondings', 'bridges', 'networks', 'nics', 'vlans'): Line 104: for dev in networking[devtype]: Line 105: dev['mtu'] = str(dev['mtu']) > Testing that this returns a string mtu is not enough, we should test that i Nir, the netinfo data used here is a copy, not cached or internal. We have tests that cover this anyway, part of the functional tests. They have been just type agnostic, so I changed that in patch 2. Line 106: return networking Line 107: Line 108: Line 109: def libvirtNets2vdsm(nets, running_config=None, routes=None, ipAddrs=None, -- To view, visit https://gerrit.ovirt.org/51164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I719ed889bfae763ce7cbed4f2aab3f6134ba2865 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
