Dan Kenigsberg has posted comments on this change. Change subject: net: mtu should be reported as a string through caps ......................................................................
Patch Set 3: (2 comments) could you state how this was verified? https://gerrit.ovirt.org/#/c/51164/3/vdsm/caps.py File vdsm/caps.py: Line 629: _getCompatibleCpuModels()) Line 630: Line 631: caps.update(_getVersionInfo()) Line 632: Line 633: # TODO: Version requests by engine to ease handling of compatability. please see current plans in https://gerrit.ovirt.org/#/c/50032/ Line 634: netinfo_data = netinfo.get_with_engine36_compatibility() Line 635: caps.update(netinfo_data) Line 636: Line 637: try: Line 634: netinfo_data I don't see benefit of defining this temporary variable. (note that in another place in this patchset you *drop* such a temporary variable). -- To view, visit https://gerrit.ovirt.org/51164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I719ed889bfae763ce7cbed4f2aab3f6134ba2865 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
