Nir Soffer has posted comments on this change. Change subject: net: mtu should be reported as a string through caps ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/51164/3/lib/vdsm/netinfo/__init__.py File lib/vdsm/netinfo/__init__.py: Line 97: Line 98: return networking Line 99: Line 100: Line 101: def get_with_engine36_compatibility(): Too ugly, we don't want such apis. Lets move this into get(compatibility=306) At the end of get(): if compatibility <= 306: networking = _strinfify_muts(networking) Line 102: # REQUIRED_FOR engine < 3.7 Line 103: return _stringify_mtus(get()) Line 104: Line 105: https://gerrit.ovirt.org/#/c/51164/3/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 406: return status, msg Line 407: Line 408: def _assert_kernel_config_matches_running_config(self): Line 409: bare_kernel_config = kernelconfig.KernelConfig( Line 410: vdsm.netinfo.CachingNetInfo()) Why is this needed? Line 411: bare_running_config = self.vdsm_net.config Line 412: normalized_running_config = kernelconfig.normalize(bare_running_config) Line 413: # Unify strings to unicode instances so differences are easier to Line 414: # understand. This won't be needed once we move to Python 3. -- To view, visit https://gerrit.ovirt.org/51164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I719ed889bfae763ce7cbed4f2aab3f6134ba2865 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
