Dan Kenigsberg has posted comments on this change. Change subject: net: mtu should be reported as a string through caps ......................................................................
Patch Set 4: -Code-Review (2 comments) https://gerrit.ovirt.org/#/c/51164/4/lib/vdsm/netinfo/__init__.py File lib/vdsm/netinfo/__init__.py: Line 107: Line 108: def get(vdsmnets=None, compatibility=None): Line 109: if compatibility is None: Line 110: return _get(vdsmnets) Line 111: elif compatibility < 370: > 370 is version 3.70, will fail for version 3.7 (major * 100 + minor). How about 30700? (I would not mind either) Line 112: # REQUIRED_FOR engine < 3.7 Line 113: return _stringify_mtus(_get(vdsmnets)) Line 114: Line 115: return _get(vdsmnets) https://gerrit.ovirt.org/#/c/51164/4/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 381: Line 382: def assertMtu(self, mtu, *elems): Line 383: # Due to compatibility with engine, the expected mtu type is string Line 384: # REQUIRED_FOR engine < 3.7 Line 385: mtu = str(mtu) > Why getMtu should return a string? We have backward compatibility layer (ne getMtu() should keep returning the MTU as reported by Vdsm's API. And we would like assert that this is a string. Line 386: for elem in elems: Line 387: self.assertEquals(mtu, self.vdsm_net.getMtu(elem)) Line 388: Line 389: def assert_active_slave_exists(self, bondName, nics): -- To view, visit https://gerrit.ovirt.org/51164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I719ed889bfae763ce7cbed4f2aab3f6134ba2865 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
