Nir Soffer has posted comments on this change. Change subject: net: mtu should be reported as a string through caps ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/51164/4/lib/vdsm/netinfo/__init__.py File lib/vdsm/netinfo/__init__.py: Line 107: Line 108: def get(vdsmnets=None, compatibility=None): Line 109: if compatibility is None: Line 110: return _get(vdsmnets) Line 111: elif compatibility < 370: > How about 30700? (I would not mind either) I think you mean 300700 (major * 10**4 + minor * 10**2 + patch). Better if we plan to change api on patch versions, but doing such changes should be avoided. However seems that we are doing this already (see "new in version" in the schema). Line 112: # REQUIRED_FOR engine < 3.7 Line 113: return _stringify_mtus(_get(vdsmnets)) Line 114: Line 115: return _get(vdsmnets) -- To view, visit https://gerrit.ovirt.org/51164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I719ed889bfae763ce7cbed4f2aab3f6134ba2865 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
