Edward Haas has posted comments on this change. Change subject: net: mtu should be reported as a string through caps ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/51164/5/lib/vdsm/netinfo/__init__.py File lib/vdsm/netinfo/__init__.py: Line 104: Line 105: return networking Line 106: Line 107: Line 108: def get(vdsmnets=None, compatibility=None): > Lets make the default 30700 That means we will need to change the default each time we add, remove of modify compatibility issues. I prefer the default to be "no compatibility' explicitly. Line 109: if compatibility is None: Line 110: return _get(vdsmnets) Line 111: elif compatibility < 30700: Line 112: # REQUIRED_FOR engine < 3.7 -- To view, visit https://gerrit.ovirt.org/51164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I719ed889bfae763ce7cbed4f2aab3f6134ba2865 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
