Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: use yum API
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File vds_bootstrap/vds_bootstrap.py
Line 964: miniyum.clean()
Line 965:
Line 966: with miniyum:
Line 967: miniyum.remove(('cman',), ignoreErrors=True)
Line 968: miniyum.install(('qemu-kvm-tools',))
Not sure... this is current implementation.
Maybe this tool is needed for GSS and not used by vdsm....
Doron?
Line 969: miniyum.installUpdate(('vdsm', 'vdsm-cli'))
Line 970:
Line 971: if installGlusterService:
Line 972: miniyum.install(('glusterfs-rdma',
'glusterfs-geo-replication'))
Line 968: miniyum.install(('qemu-kvm-tools',))
Line 969: miniyum.installUpdate(('vdsm', 'vdsm-cli'))
Line 970:
Line 971: if installGlusterService:
Line 972: miniyum.install(('glusterfs-rdma',
'glusterfs-geo-replication'))
Same question applies to this gluster packages, why aren't they dependency of
vdsm-gluster.... or maybe they are...
Line 973: miniyum.installUpdate(('vdsm-gluster',))
Line 974:
Line 975: if miniyum.buildTransaction():
Line 976: miniyum.processTransaction()
--
To view, visit http://gerrit.ovirt.org/8039
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65796801bc2db7c5abf71c1e9e4ad8ca308138b9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Pradipta Banerjee <[email protected]>
Gerrit-Reviewer: Rodrigo Trujillo <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
