Martin Polednik has posted comments on this change. Change subject: caps: refactor cpuinfo parsing ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51523/1/vdsm/caps.py File vdsm/caps.py: Line 87 Line 88 Line 89 Line 90 Line 91 > This is too complex for no reason. We read and parse cpuinfo once per vdsm Thank you for the comment! I agree about the code being overly complicated. One thing that I do not like is reading a specific amount of bytes as on Intel/AMD, the information is most likely in the 4096 bytes. But on the entry-level ppc the file is 9010 bytes long and the values are at offset ~8800. The class is removed in the move to cpuinfo module, this is a step to refactor the parsing *before* moving it in order to have the module nice and clean. -- To view, visit https://gerrit.ovirt.org/51523 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib705bba4789bd1938bf26ae387af72b079020ce7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
