Francesco Romani has posted comments on this change. Change subject: caps: refactor cpuinfo parsing ......................................................................
Patch Set 5: Code-Review+2 (1 comment) Martin, great job. Please tick Verified. https://gerrit.ovirt.org/#/c/51523/5/vdsm/caps.py File vdsm/caps.py: Line 92: Line 93: class CpuInfo(object): Line 94: def __init__(self, cpuinfo='/proc/cpuinfo'): Line 95: """Parse /proc/cpuinfo""" Line 96: self.fields = {} for a future patch: drop the code which accesses this field from the outside, than make it private. Line 97: Line 98: if cpuarch.is_ppc(cpuarch.real()): Line 99: self.fields['flags'] = ['powernv'] Line 100: -- To view, visit https://gerrit.ovirt.org/51523 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib705bba4789bd1938bf26ae387af72b079020ce7 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
