Dan Kenigsberg has submitted this change and it was merged. Change subject: Validate downloaded SSH public key ......................................................................
Validate downloaded SSH public key During registration the SSH public key of the engine is downloaded, but it is not verified in any way. In some situations we can be getting garbage from the server, for example when we connect to an HTTPS server using the HTTP protocol. That garbage can end up in the uthorized_keys file. This patch changes deployUtils.py so that it verifies that what we get looks like a valid SSH public key before saving it to the file. Bug-Id: https://bugzilla.redhat.com/856167 Change-Id: Ic6873690534f431867859e91b5fb6b1f693155aa Signed-off-by: Juan Hernandez <[email protected]> --- M vdsm_reg/deployUtil.py.in 1 file changed, 25 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Douglas Schilling Landgraf: Looks good to me, but someone else must approve Ryan Harper: Looks good to me, but someone else must approve Juan Hernandez: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6873690534f431867859e91b5fb6b1f693155aa Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Burns <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
