Alon Bar-Lev has posted comments on this change.
Change subject: BZ#856167 - Validate downloaded SSH public key
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File vdsm_reg/deployUtil.py.in
Line 683: return selinux.restorecon(path)
Line 684: except:
Line 685: logging.error('restorecon %s failed', path, exc_info=True)
Line 686:
Line 687: def validateSSHKey(strKey):
minor comment... I think best to avoid this one line functions... but it is a
matter of taste I guess... :)
Line 688: """
Line 689: Check that the given string is a valid SSH public key in the
Line 690: format used by OpenSSH
Line 691: """
--
To view, visit http://gerrit.ovirt.org/8018
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6873690534f431867859e91b5fb6b1f693155aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Michael Burns <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
