Ryan Harper has posted comments on this change. Change subject: BZ#856167 - Validate downloaded SSH public key ......................................................................
Patch Set 4: I would prefer that you didn't submit this (1 inline comment) Code looks fine, just a minor nit to fixup. .................................................... File vdsm_reg/deployUtil.py.in Line 686: Line 687: def validateSSHKey(strKey): Line 688: """ Line 689: Check that the given string is a valid SSH public key in the Line 690: format used by OpenSSH Dan pointed out on other patches, following: http://www.python.org/dev/peps/pep-0257/ docstrings aren't indented. It's not uniformly applied to this file, but let's not make it worse. Line 691: """ Line 692: if SSH_PUBLIC_KEY_RE.match(strKey) is None: Line 693: logging.debug("validateSSHKey: the string \"%s\" is not a valid SSH key" % strKey) Line 694: return False -- To view, visit http://gerrit.ovirt.org/8018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6873690534f431867859e91b5fb6b1f693155aa Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Burns <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
