Saggi Mizrahi has posted comments on this change.

Change subject: Fix onDomainConnectivityStateChange in DomainMonitorThread
......................................................................


Patch Set 4: I would prefer that you didn't submit this

I don't understand why that fixes. And I don't understand why you didn't also 
add DomainMonitorStrings class to put all the string fields of domain monitor 
in it

--
To view, visit http://gerrit.ovirt.org/7772
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3b7e7c788b54726a3c820f4f2180884c74d93ef
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to