Saggi Mizrahi has posted comments on this change.
Change subject: domain: fix onDomainConnectivityStateChange attribute
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/domainMonitor.py
Line 216: self.log.debug("Domain %s changed its status to %s",
self.sdUUID,
Line 217: "Valid" if self.nextStatus.valid else
"Invalid")
Line 218:
Line 219: try:
Line 220: self.domainMonitor.onDomainConnectivityStateChange \
domain monitor is now a weakref.ref object.
you "call" it to get a hard ref to the underlying object.
ref = self.domainMonitor()
if ref is None:
# object was released
else:
# object is alive and kicking
Line 221: .emit(self.sdUUID,
self.nextStatus.valid)
Line 222: except:
Line 223: self.log.warn("Could not emit domain state change
event",
Line 224: exc_info=True)
--
To view, visit http://gerrit.ovirt.org/7772
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3b7e7c788b54726a3c820f4f2180884c74d93ef
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
