Saggi Mizrahi has posted comments on this change. Change subject: domain: fix onDomainConnectivityStateChange attribute ......................................................................
Patch Set 8: (1 inline comment) .................................................... File vdsm/storage/domainMonitor.py Line 114: def __init__(self, domainMonitor, sdUUID, hostId, interval): Line 115: self.thread = Thread(target=self._monitorLoop) Line 116: self.thread.setDaemon(True) Line 117: Line 118: self.domainMonitor = weakref.proxy(domainMonitor) Might be better to have the proxy sent tot he object rather then it creating it. Will be more resilient in case you manage to break the circular dependency. Line 119: self.stopEvent = Event() Line 120: self.domain = None Line 121: self.sdUUID = sdUUID Line 122: self.hostId = hostId -- To view, visit http://gerrit.ovirt.org/7772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3b7e7c788b54726a3c820f4f2180884c74d93ef Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
