Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: use yum API ......................................................................
Patch Set 9: (3 inline comments) .................................................... File vds_bootstrap/miniyum.py Line 446: self._yb.repos.setProgressBar( Line 447: MiniYum._downloadcallback(self._sink) Line 448: ) Line 449: Line 450: except YumBaseError as e: I'm not saying not to log - I ask why you are not re-raising the exception. (and why you have different handling for the two exceptions...) Line 451: self._sink.error(str(e.value)) Line 452: except Exception as e: Line 453: self._sink.error(str(e)) Line 454: Line 459: to adjust proper roles for selinux. Line 460: it will re-execute the process with same arguments. Line 461: Line 462: This has similar effect of: Line 463: # chcon -t rpm_exec_t miniyum.py I am trying to understand why you cannot replace selinux_role() with setup.py executing vds_bootstrap.py with the proper chcon games. I know that you've already answered me - but I did not understad the answer about worse case/best case. Line 464: Line 465: We must do this dynamic as this class is to be Line 466: used at bootstrap stage, so we cannot put any Line 467: persistent selinux policy changes. Line 513: self._yb.cleanMetadata() Line 514: self._yb.cleanPackages() Line 515: self._yb.cleanSqlite() Line 516: Line 517: def install(self, packages, **kwargs): imo, better leave it as it is Line 518: """Install packages. Line 519: Line 520: Keyword arguments: Line 521: packages -- packages to install. -- To view, visit http://gerrit.ovirt.org/8039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65796801bc2db7c5abf71c1e9e4ad8ca308138b9 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Pradipta Banerjee <[email protected]> Gerrit-Reviewer: Rodrigo Trujillo <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
