Alon Bar-Lev has posted comments on this change.

Change subject: bootstrap: use yum API
......................................................................


Patch Set 9: (1 inline comment)

....................................................
File vds_bootstrap/vds_bootstrap.py
Line 126:             hexkeyid
Line 127:         )
Line 128:         logging.warning("MiniYum: WARN:  %s", msg)
Line 129:         self._status('WARN', msg)
Line 130:         return True
# yum install vdsm
 <snip>
 warning: rpmts_HdrFromFdno: Header V3 RSA/SHA256 Signature, key ID fd431d51: 
NOKEY
 Retrieving key from file:///etc/pki/rpm-gpg/RPM-GPG-KEY-redhat-release
 Importing GPG key 0xFD431D51:
  Userid : Red Hat, Inc. (release key 2) <[email protected]>
  Package: redhat-release-server-6Server-6.3.0.3.el6.x86_64 
(@anaconda-RedHatEnterpriseLinux-201206132210.x86_64/6.3)
  From   : /etc/pki/rpm-gpg/RPM-GPG-KEY-redhat-release
 Is this ok [y/N]: 

 # yum -y install vdsm
 warning: rpmts_HdrFromFdno: Header V3 RSA/SHA256 Signature, key ID fd431d51: 
NOKEY
 Retrieving key from file:///etc/pki/rpm-gpg/RPM-GPG-KEY-redhat-release
 Importing GPG key 0xFD431D51:
  Userid : Red Hat, Inc. (release key 2) <[email protected]>
  Package: redhat-release-server-6Server-6.3.0.3.el6.x86_64 
(@anaconda-RedHatEnterpriseLinux-201206132210.x86_64/6.3)
  From   : /etc/pki/rpm-gpg/RPM-GPG-KEY-redhat-release
 Importing GPG key 0x2FA658E0:
  Userid : Red Hat, Inc. (auxiliary key) <[email protected]>
  Package: redhat-release-server-6Server-6.3.0.3.el6.x86_64 
(@anaconda-RedHatEnterpriseLinux-201206132210.x86_64/6.3)
  From   : /etc/pki/rpm-gpg/RPM-GPG-KEY-redhat-release

So yes, current implementation accepts keys automatically. No regression.
Line 131: 
Line 132: 
Line 133: rhel6based = deployUtil.versionCompare(deployUtil.getOSVersion(), 
"6.0") >= 0
Line 134: 


--
To view, visit http://gerrit.ovirt.org/8039
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65796801bc2db7c5abf71c1e9e4ad8ca308138b9
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Pradipta Banerjee <[email protected]>
Gerrit-Reviewer: Rodrigo Trujillo <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to