Alon Bar-Lev has posted comments on this change. Change subject: bootstrap: use yum API ......................................................................
Patch Set 9: (2 inline comments) Thanks! .................................................... File vds_bootstrap/miniyum.py Line 446: self._yb.repos.setProgressBar( Line 447: MiniYum._downloadcallback(self._sink) Line 448: ) Line 449: Line 450: except YumBaseError as e: Yes, now that I only print e, I do not need both. I raise the exception for people to be able to catch... what exactly do you have in mind? perform return False? Line 451: self._sink.error(str(e.value)) Line 452: except Exception as e: Line 453: self._sink.error(str(e)) Line 454: Line 459: to adjust proper roles for selinux. Line 460: it will re-execute the process with same arguments. Line 461: Line 462: This has similar effect of: Line 463: # chcon -t rpm_exec_t miniyum.py To mark executable with attributes you need filesystem that supports extended attributes, and mounted with extended attribute, this is not given. And, you need root to be in proper selinux context. And... we do not run the miniyum, we import it. So we need to re-execute <something> anyway... even if we put the role on file. Is that more clear? Line 464: Line 465: We must do this dynamic as this class is to be Line 466: used at bootstrap stage, so we cannot put any Line 467: persistent selinux policy changes. -- To view, visit http://gerrit.ovirt.org/8039 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65796801bc2db7c5abf71c1e9e4ad8ca308138b9 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Pradipta Banerjee <[email protected]> Gerrit-Reviewer: Rodrigo Trujillo <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
