Ryan Harper has posted comments on this change.

Change subject: storage: Default to NFSv3 if version not specified
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

Np, looks good.  

I did have a question about when version is set to 'auto'.  In this case, we'll 
need to execute the code to try to determine the version.  If we don't expect 
the version to change at runtime, we could keep the discovery value around to 
avoid the addition check anytime someone references the property.

--
To view, visit http://gerrit.ovirt.org/8241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83307ecd8262688f3d4ddb43b62a79924ecfc62c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to