Alon Bar-Lev has posted comments on this change. Change subject: setup: move the the certificate generation ......................................................................
Patch Set 1: (1 inline comment) Thanks!!! Questions: 1. If we run on ovirt-node, shouldn't we persist? 2. I would have created all the files in temporary folder, and if all the process succeeded move to final destination. I don't think there is real value in partial files. What do you think? .................................................... File vdsm/vdsm-gencerts.sh.in Line 115: /sbin/restorecon "$__vdsm_gencerts_crt" Line 116: /bin/rm -f "$__vdsm_gencerts_template" Line 117: } Line 118: Line 119: if [ "$1" != "--bash-import" ]; then --sh-import? :) Line 120: vdsm_create_key Line 121: vdsm_create_ca Line 122: vdsm_create_cert -- To view, visit http://gerrit.ovirt.org/8368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40fa3d9a6a54e312e399af3f87ac67e843078360 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
