Federico Simoncelli has posted comments on this change. Change subject: setup: move the certificate generation ......................................................................
Patch Set 2: > I still think the whole process should either succeed or fail. No use for key > that is left over nor CA or certificate. > Resources should be generated in temporary location and only if all process > succeed move into final position. Wrong, if you already have a pre-generated key (and/or ca) and you want to create an host certificate from it you just need to put the key/ca in the proper place. > The node support should part of this change, no mater if you think it should > be done in vdsm-reg or in vdsm init.d, but persisting it is something that > should be done, if not, every boot will regenerate a certificate. I don't understand why you want to persist a key/certificate that is of no use. The one you want to persist is the one coming from the engine. What do you care to persist a temporary certificate. I even suggested to persist the correct ones (downloaded from the engine) even before starting vdsm. -- To view, visit http://gerrit.ovirt.org/8368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40fa3d9a6a54e312e399af3f87ac67e843078360 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
