Federico Simoncelli has posted comments on this change. Change subject: setup: move the certificate generation ......................................................................
Patch Set 2: > 1. I personally don't like leftovers as the iterative creation of a->b->c may > lead to c always fails if b is a bad resource. Creating the whole chain upon > failure has higher chance to success, as this is the atomic transaction we > need, either to succeed or fail. But I won't make life harder in this regard. There are no leftovers, if b is a bad source it's because certtool failed, but we already check that and we don't move the file into place in that case. If certtool succeeded but the generated file is not valid then it means that certtool is in serious trouble. > 2. As far as I know ssh keys are persisted. Not sure at which point. But I > don't get invalid key when rebooting. Ok good, so we agree that they should be persisted somewhere else. -- To view, visit http://gerrit.ovirt.org/8368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40fa3d9a6a54e312e399af3f87ac67e843078360 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
