Shireesh Anjal has posted comments on this change.

Change subject: bootstrap: allow customize bridge name for standard sequence
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vds_bootstrap/setup
Line 292:         engine_ssh_key = None
Line 293:         rebootAfterInstallation = False
Line 294:         installVirtualizationService = True
Line 295:         installGlusterService = False
Line 296:         bridgeName = False
Should the bridgeName be initialized with None rather than False ?
Line 297:         opts, args = getopt.getopt(sys.argv[1:], 
"c:m:r:O:t:p:bf:S:gB:Vv:")
Line 298:         for o,v in opts:
Line 299:             if o == "-v":
Line 300:                 bootstrap_interface_version = int(v)


--
To view, visit http://gerrit.ovirt.org/8388
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70c178de55e14ecdcff92270df489dc1415ef26f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to