Dan Kenigsberg has posted comments on this change. Change subject: bootstrap: allow customize bridge name for standard sequence ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm_reg/deployUtil.py.in Line 1033: ( Line 1034: "makeBridge Failed to add %s bridge out=%s\n" Line 1035: "err=%s\n" Line 1036: "ret=%s" Line 1037: ) % (bridgeName, out, str(err), str(ret)) oops, missed the err = None assignments high up. Sorry. Just a small note: it is better practice to pass the (bridgeName, out, err, ret) variables as extra args to logging.debug() and its friends. logging.debug(format_str, bridgeName, out, err, ret) this way, string formatting is avoided when logging is not verbose. Line 1038: ) Line 1039: Line 1040: #Save current config by removing the undo files: Line 1041: try: -- To view, visit http://gerrit.ovirt.org/8388 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70c178de55e14ecdcff92270df489dc1415ef26f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
