Alon Bar-Lev has posted comments on this change.
Change subject: bootstrap: allow customize bridge name for standard sequence
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File vdsm_reg/deployUtil.py.in
Line 926: "_getRHELBridgeParams Found bonding: %s."
Line 927: "This network configuration is not"
Line 928: "supported! Please configure %s bridge"
Line 929: "manually and re-install."
Line 930: ) % (str(nic), bridgeName)
Done
Line 931: )
Line 932: nic = None
Line 933: except:
Line 934: logging.error("_getRHELBridgeParams Failed to test for VLAN
data")
Line 1033: (
Line 1034: "makeBridge Failed to add %s bridge out=%s\n"
Line 1035: "err=%s\n"
Line 1036: "ret=%s"
Line 1037: ) % (bridgeName, out, str(err), str(ret))
They are assigned on top of the function, so they are defined.... not that this
is good but as-is.
Removed the str()
Line 1038: )
Line 1039:
Line 1040: #Save current config by removing the undo files:
Line 1041: try:
--
To view, visit http://gerrit.ovirt.org/8388
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I70c178de55e14ecdcff92270df489dc1415ef26f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
