Edward Haas has posted comments on this change. Change subject: contrib: schema converter ......................................................................
Patch Set 17: (4 comments) I know it has already been discussed, but I would really prefer having individual small yaml files. Maybe having *.yaml.in files that get merged to a yuml during the build? BTW, can we migrate to yaml in stage? removing from one and adding to the other per verb? This will allow small steps of pushing yaml in. https://gerrit.ovirt.org/#/c/52864/17/lib/api/vdsm-api.yaml File lib/api/vdsm-api.yaml: Line 4836: defaultvalue How is the defaultvalue intended to work? We have defaults on many keys, but there are some that their absence has its own meaning. What is the rule? Where should we update the defaults? Directly here into the yaml file? Won't that collide with changes in the json files now? (converting won't clear the defaults?) Line 4839: name nit: Can we have 'name' be placed first? Seeing the default first is a bit confusing... Line 4846: : - is this a glitch? Line 4849: null Default value of a custom type? -- To view, visit https://gerrit.ovirt.org/52864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
