Edward Haas has posted comments on this change. Change subject: contrib: schema converter ......................................................................
Patch Set 17: (3 comments) After going over several defaults, it seems it requires a substantial effort. We have started using at the api entry point a canonicalize stage, where we set defaults and convert input to proper types (so we won't need to do so later on). In order to confirm networking defaults, we need to first set it in the canonicalization stage, test it and only then set it in the schema. Having defaults, even 'None', have implications on the persistent data we save as config files and on processing old persistent files that are being restored (and do not pass the schema). https://gerrit.ovirt.org/#/c/52864/17/lib/api/vdsm-api.yaml File lib/api/vdsm-api.yaml: Line 4805: needs updating Our code assumes no default exists for this attribute. Line 4816: needs updating null Line 4836: null 'none' -- To view, visit https://gerrit.ovirt.org/52864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
