Federico Simoncelli has posted comments on this change. Change subject: setup: move the certificate generation ......................................................................
Patch Set 2: > 2. It should be persist by any tool/place by this patch. /me/ just added this > to the init.d script. if you find another place that is appropriate feel free > to do so. There are several reason why your request can't be fulfilled, first of all persisting in the vdsm init file is just plain wrong (no other rhel/fedora service that does that). Second, it's not what the bug states: "vdsm should generate keys and certificate when init.d script is started and not when installed". And third, no matter what, it can't be done here because what you need is in the ovirt-node repository (ovirt_store_firstboot_config) and we can't address it in one patch. If you really want to persist these temporary keys/certificates (useless IMHO) then the correct thing to do is to open an additional bug on ovirt-node and take it from there. -- To view, visit http://gerrit.ovirt.org/8368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40fa3d9a6a54e312e399af3f87ac67e843078360 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
