Igor Lvovsky has posted comments on this change.
Change subject: [WIP] BZ#855924 fix VM config dictionary
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/vm.py
Line 93: self._method = method
Line 94: self._dstparams = dstparams
Line 95: # for now have this hardcoded to hot-fix 3.1 -> 3.0 issue
Line 96: # later look for getVersion() call or like that
Line 97: self._dst_version = "3.0"
Actually, I think to implement getVersiopn is too simple and you can do it in
separate patch (before this one).
I hate this hard coded stuff
Line 98: self._machineParams = {}
Line 99: self._downtime = kwargs.get('downtime') or \
Line 100: config.get('vars', 'migration_downtime')
Line 101: self.status = {'status': {'code': 0, 'message': 'Migration in
process'}, 'progress': 0}
Line 227: try:
Line 228: # add cdrom and floppy as paths
Line 229: self._vm.conf[i] = [x['path'] for x in \
Line 230: self._vm.conf['drives'] if
x['device'] == i][0]
Line 231: # remove them from 'devices' list
why? what if you will migrate VM back?
Line 232: [self._vm.conf['drives'].pop(
Line 233: self._vm.conf['drives'].index(z)) \
Line 234: for z in [x for x in \
Line 235: self._vm.conf['drives'] if
x['device'] == i]]
--
To view, visit http://gerrit.ovirt.org/8378
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I33e957f8daac4266d9e19cc008cf830bd3959521
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
