Igor Lvovsky has posted comments on this change. Change subject: [WIP] BZ#855924 fix VM config dictionary ......................................................................
Patch Set 4: (1 inline comment) .................................................... File vdsm/vm.py Line 227: try: Line 228: # add cdrom and floppy as paths Line 229: self._vm.conf[i] = [x['path'] for x in \ Line 230: self._vm.conf['drives'] if x['device'] == i][0] Line 231: # remove them from 'devices' list 1. you wrote 'devices' in comment 2. no one put cdrom/floppy in 'drives' list Line 232: [self._vm.conf['drives'].pop( Line 233: self._vm.conf['drives'].index(z)) \ Line 234: for z in [x for x in \ Line 235: self._vm.conf['drives'] if x['device'] == i]] -- To view, visit http://gerrit.ovirt.org/8378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33e957f8daac4266d9e19cc008cf830bd3959521 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
