Vinzenz Feenstra has posted comments on this change. Change subject: [WIP] BZ#855924 fix VM config dictionary ......................................................................
Patch Set 5: (1 inline comment) .................................................... Commit Message Line 10: The issue is that 3.0 defines cdrom and floppy as dedicated Line 11: dictionary keys, while 3.1 places them among other devices. Line 12: Line 13: Right now the only way to discover the VDSM version is Line 14: getVdsCapabilities() call, but it takes too long time and This should be no longer mentioned as you're now using getVersionInfo Line 15: causes timeouts, so we can not use it. A hotfix is to assume Line 16: the compatibility level always 3.0. Later it can be fixed Line 17: with a dedicated getVersion() (or like that) call Line 18: -- To view, visit http://gerrit.ovirt.org/8378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I33e957f8daac4266d9e19cc008cf830bd3959521 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
