Nir Soffer has posted comments on this change. Change subject: contrib: schema converter ......................................................................
Patch Set 23: (2 comments) https://gerrit.ovirt.org/#/c/52864/23/contrib/schema-converter File contrib/schema-converter: Line 26: json_schema_path - path where json schema is located Line 27: Line 28: yaml_schema_path - path where yaml schema is written Line 29: """ Line 30: from api import vdsmapi Should be at the end of the imports as ths is the most specific import. Also, this import cannot work - we cannot have package called "api" in the top level namespace. We can have vdsm.api. If you are importing stuff from the current package, use: from . import vdsmapi Line 31: Line 32: import sys Line 33: import yaml Line 34: Line 29: """ Line 30: from api import vdsmapi Line 31: Line 32: import sys Line 33: import yaml This is not from standard library, so it should be after the collections import. The order should be (stdlib, 3rd party libs, vdsm lib, application) Line 34: Line 35: from collections import OrderedDict Line 36: Line 37: -- To view, visit https://gerrit.ovirt.org/52864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
