Piotr Kliczewski has posted comments on this change. Change subject: contrib: schema converter ......................................................................
Patch Set 22: (2 comments) https://gerrit.ovirt.org/#/c/52864/22/lib/api/vdsmapi.py File lib/api/vdsmapi.py: Line 333: symbol.update({'name': name, 'info_data': {}, 'info_return': '', Line 334: 'xxx': []}) Line 335: Line 336: # Pop a blank line Line 337: assert('' == lines.pop(0)) > asserts must not have side effects, since they are eliminated when running Done Line 338: Line 339: # Grab the entity description. It might span multiple lines. Line 340: symbol['desc'] = lines.pop(0) Line 341: while (lines[0] != ''): Line 341: while (lines[0] != ''): Line 342: symbol['desc'] += lines.pop(0) Line 343: Line 344: # Pop a blank line Line 345: assert ('' == lines.pop(0)) > Same Done Line 346: Line 347: # Populate the rest of the human-readable data. Line 348: # First try to read the parameters/members information. We are finished Line 349: # once we read a <tag>: line. After reading a 'Returns:' tag, we will try -- To view, visit https://gerrit.ovirt.org/52864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
