Ryan Harper has posted comments on this change. Change subject: volume: remove domain shared lock from getVolumeSize ......................................................................
Patch Set 1: (1 inline comment) Does the file now pass pep8 check? If not, then let's do all pep8 changes needed in a single patch and add it to the whitelist. .................................................... Commit Message Line 17: either succeed or fail without undesiderable side effects. Line 18: Line 19: In this patch: Line 20: * remove the getSharedLock from getVolumeSize Line 21: * make the involved code pep8 compliant PEP8 changes should be separate patches. Line 22: Line 23: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=865386 Line 24: Signed-off-by: Federico Simoncelli <[email protected]> -- To view, visit http://gerrit.ovirt.org/8517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I644fff245b62ef009a4ca7b6f4a903c9ffcc9653 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
