Dan Kenigsberg has posted comments on this change. Change subject: volume: remove domain shared lock from getVolumeSize ......................................................................
Patch Set 2: I agree that "these calls can either succeed or fail without undesirable side effects". But what about removing storage domain while an lv is held by one of these methods? Wouldn't it leave the domain half-dead? -- To view, visit http://gerrit.ovirt.org/8517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I644fff245b62ef009a4ca7b6f4a903c9ffcc9653 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
