Dan Kenigsberg has submitted this change and it was merged. Change subject: volume: remove domain shared lock from getVolumeSize ......................................................................
volume: remove domain shared lock from getVolumeSize During long operations involving an exclusive lock on a storage domain (e.g.: domain upgrade) the getVolumeSize calls coming from the VmStatsThread are queued and the statsAge grows until the VMs are moved to not-responding. Also the extendVolume requests are queued (with requests coming from other hosts in the cluster) and the (redundant) refreshVolume issued by the VMs on the SPM. Removing the getSharedLock call from such methods is the safest way to fix the issue since we don't use more granular locks during the upgrade (image/volume locks) and these calls can either succeed or fail without undesirable side effects. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=865386 Signed-off-by: Federico Simoncelli <[email protected]> Change-Id: I644fff245b62ef009a4ca7b6f4a903c9ffcc9653 --- M vdsm/storage/hsm.py 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Ayal Baron: Looks good to me, approved Federico Simoncelli: Verified Allon Mureinik: Looks good to me, but someone else must approve Dan Kenigsberg: -- To view, visit http://gerrit.ovirt.org/8517 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I644fff245b62ef009a4ca7b6f4a903c9ffcc9653 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
