Nir Soffer has posted comments on this change. Change subject: contrib: schema converter ......................................................................
Patch Set 25: (3 comments) https://gerrit.ovirt.org/#/c/52864/25/tests/schemaValidationTest.py File tests/schemaValidationTest.py: Line 77 Line 78 Line 79 Line 80 Line 81 Why do we need to change this test? Line 36: from nose.plugins.skip import SkipTest Line 37: Line 38: Line 39: @contextmanager Line 40: def schema_not_found(): Why do we need this? Line 41: try: Line 42: yield Line 43: except schemaapi.SchemaNotFound: Line 44: raise SkipTest('yaml schema not available') Line 194: else: Line 195: return None Line 196: Line 197: Line 198: class JsonToYamlValidation(TestCaseBase): To test the yaml schema, we don't need to find the schema. The test should: - Convert the json schema to yaml - Read both json and yaml schema - Normalized type names (e.g. str/string) - Verify that both are the same This is the only thing we need to replace the json schema with yaml. Line 199: Line 200: def swap_types(self, name): Line 201: if name == 'str': Line 202: return 'string' -- To view, visit https://gerrit.ovirt.org/52864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
