Piotr Kliczewski has posted comments on this change.

Change subject: vm: improve safety between startup and shutdown
......................................................................


Patch Set 5:

(3 comments)

https://gerrit.ovirt.org/#/c/44989/5/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

PS5, Line 7051: .
This dot is not needed.


PS5, Line 7051:  
We do not need this space here.


https://gerrit.ovirt.org/#/c/44989/5/lib/vdsm/virt/vmexitreason.py
File lib/vdsm/virt/vmexitreason.py:

PS5, Line 46: ,
In old version we had no comma at the end. Do we need it now?


-- 
To view, visit https://gerrit.ovirt.org/44989
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8718f58f1d255d9e603db75aa1f256c03c300f3a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Milan Zamazal <[email protected]>
Gerrit-Reviewer: Piotr Kliczewski <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: gerrit-hooks <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to