Martin Polednik has posted comments on this change. Change subject: vm: improve safety between startup and shutdown ......................................................................
Patch Set 7: (9 comments) Not-so-well worded message, and my gerrit doesn't show +1/-1 buttons. https://gerrit.ovirt.org/#/c/44989/6//COMMIT_MSG Commit Message: PS6, Line 9: the You are already refering to 'the flows' with the first the. PS6, Line 12: on in PS6, Line 13: _means_ PS6, Line 14: 's PS6, Line 15: learn learning PS6, Line 15: to drop PS6, Line 19: start starts https://gerrit.ovirt.org/#/c/44989/7/lib/vdsm/virt/vmexitreason.py File lib/vdsm/virt/vmexitreason.py: PS7, Line 34: Unrelated, do we really want 2 newlines here? https://gerrit.ovirt.org/#/c/44989/6/vdsm/virt/vm.py File vdsm/virt/vm.py: PS6, Line 2305: self._waitForDeviceRemoval(nic) : except HotunplugTimeout as e: Have you rebased properly? Why is it showing up here? -- To view, visit https://gerrit.ovirt.org/44989 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8718f58f1d255d9e603db75aa1f256c03c300f3a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
