Francesco Romani has posted comments on this change. Change subject: vm: improve safety between startup and shutdown ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/44989/5/vdsm/virt/vm.py File vdsm/virt/vm.py: PS5, Line 90: _DESTROY_ON_STARTUP_TIMEOUT = 30 # seconds > Arbitrary or backed up? Completely arbitrary. PS5, Line 192: class DestroyedOnStartupError(Exception): : """ : Domain destroyed during startup process. : """ > (not related to *this* patch) do we have plans to move the exceptions to th yep, probably like lib/vdsm/virt/exceptions.py - to be used internally *in Vdsm*, not part of any external API (e.g. with Engine). This is queued up behind currently started cleanups. -- To view, visit https://gerrit.ovirt.org/44989 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8718f58f1d255d9e603db75aa1f256c03c300f3a Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
