Dan Kenigsberg has posted comments on this change.
Change subject: report cpuUser and cpuSys separately (#800367)
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
Thanks for ping'ing - I've missed your wiki page update. I have only one worry
about log flooding.
....................................................
File vdsm/libvirtvm.py
Line 181: self._diff(eInfo, sInfo, 'cpu_time')
Line 182: - self._diff(eInfo, sInfo, 'user_time')
Line 183: - self._diff(eInfo, sInfo, 'system_time'),
Line 184: sampleInterval)
Line 185: self._log.debug('system load: %d, guest load %d',
I think this would spam our logs too much - wouldn't it? think 100 VMs being
polled every 10 seconds.
Line 186: stats['cpuSys'], stats['cpuUser'])
Line 187:
Line 188: except (TypeError, ZeroDivisionError) as e:
Line 189: self._log.debug("CPU stats not available: %s", e)
--
To view, visit http://gerrit.ovirt.org/7718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I663ad25ff3ff5ce426b5159b6c9a65b7f5167605
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Geert Jansen <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
