Piotr Kliczewski has posted comments on this change. Change subject: events: introduction of schema ......................................................................
Patch Set 11: Verified+1 (1 comment) Verified by updating vdsm and changing the status of a vm several times. https://gerrit.ovirt.org/#/c/54754/7/lib/api/vdsmapi.py File lib/api/vdsmapi.py: Line 294: Line 295: if ret_args: Line 296: self._verify_type(ret_args.get('type'), ret, Line 297: '%s.%s' % (class_name, method_name)) Line 298: except Exception as e: > I think this patch will look much easier to review if you move this identif Done Line 299: if type(e).__name__ == 'JsonRpcInvalidParamsError': Line 300: raise Line 301: Line 302: self._report_inconsistency('Unexpected issue with response type' -- To view, visit https://gerrit.ovirt.org/54754 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43a9f1852b1459a2e905244049507704f0187201 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
