Petr Horáček has posted comments on this change. Change subject: net: add rollback_trigger to Config() ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/56149/3/lib/vdsm/netconfpersistence.py File lib/vdsm/netconfpersistence.py: Line 201: self.bondingsPath) Line 202: _clear_dir(self.networksPath) Line 203: _clear_dir(self.bondingsPath) Line 204: Line 205: @contextmanager > Proposing something a bit different: That looks good, but i think we need to keep config.save() outside. we should create a draft of switch migration to obtain a better image. when should we run config.save(), how to keep minimal changes in current legacy rollback code, etc. Line 206: def rollback_trigger(self, in_rollback): Line 207: self._backup = deepcopy(self) Line 208: try: Line 209: yield -- To view, visit https://gerrit.ovirt.org/56149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab1dcf346a5d5de15f01148a58abc4ae6e0ab97d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
