Petr Horáček has posted comments on this change. Change subject: net: add Transaction() to netconfpersistence ......................................................................
Patch Set 8: Verified+1 (3 comments) Passed conf_persistence_test.py. https://gerrit.ovirt.org/#/c/56149/7/lib/vdsm/netconfpersistence.py File lib/vdsm/netconfpersistence.py: PS7, Line 231: retur > return Done https://gerrit.ovirt.org/#/c/56149/7/tests/network/conf_persistence_test.py File tests/network/conf_persistence_test.py: PS7, Line 51: _create_netconf(): > nit: _create_netconf Done Line 134: Line 135: def tearDown(self): Line 136: rmtree(self.tempdir) Line 137: Line 138: def test_successful_setup(self): > You can move now: only Config, Transaction has variable params Line 139: with Transaction(config=self.config) as _config: Line 140: _config.setNetwork(NETWORK, NETWORK_ATTRIBUTES) Line 141: Line 142: file_path = os.path.join(self.tempdir, 'nets', NETWORK) -- To view, visit https://gerrit.ovirt.org/56149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab1dcf346a5d5de15f01148a58abc4ae6e0ab97d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
