Edward Haas has posted comments on this change. Change subject: net: add Transaction() to netconfpersistence ......................................................................
Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/56149/7/tests/network/conf_persistence_test.py File tests/network/conf_persistence_test.py: PS7, Line 51: create_netconf_temp_dir nit: _create_netconf Line 134: def tearDown(self): Line 135: rmtree(self.tempdir) Line 136: Line 137: def test_successful_setup(self): Line 138: config = Config(self.tempdir) You can move now: config = Config(self.tempdir) and Transaction(config=config) to the setUp Line 139: Line 140: with Transaction(config=config) as _config: Line 141: _config.setNetwork(NETWORK, NETWORK_ATTRIBUTES) Line 142: -- To view, visit https://gerrit.ovirt.org/56149 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab1dcf346a5d5de15f01148a58abc4ae6e0ab97d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
